Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure kubekins dockerd to use mirror.gcr.io #19780

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Configure kubekins dockerd to use mirror.gcr.io #19780

merged 1 commit into from
Oct 30, 2020

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Oct 30, 2020

Follow instructions from https://cloud.google.com/container-registry/docs/pulling-cached-images

This is intended for jobs that use docker-in-docker via the preset-dind-enabled preset and also use the kubekins image

ref: #19477

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/images area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 30, 2020
@spiffxp
Copy link
Member Author

spiffxp commented Oct 30, 2020

/cc @BenTheElder

@MushuEE
Copy link
Contributor

MushuEE commented Oct 30, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit f2c8e70 into kubernetes:master Oct 30, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 30, 2020
@spiffxp spiffxp deleted the kubekins-use-mirror-gcr-io branch October 30, 2020 18:15
@spiffxp
Copy link
Member Author

spiffxp commented Oct 30, 2020

Waiting on postsubmit to build https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-test-infra-push-kubekins-e2e/1322240454648926208

@spiffxp
Copy link
Member Author

spiffxp commented Oct 30, 2020 •
edited
Loading

2020-10-30 18:23:26 UTC - image pushed by https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-test-infra-push-kubekins-e2e/1322240454648926208
2020-10-30 18:50:10 UTC - image used by https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/ci-kubernetes-e2e-gce-canary/1322249448511770624 (which passed)

So this hasn't broken things

@BenTheElder
Copy link
Member

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus Awaiting requested review from justaugustus

@MushuEE MushuEE Awaiting requested review from MushuEE

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@MushuEE MushuEE

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/images area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
4 participants
@spiffxp @k8s-ci-robot @MushuEE @BenTheElder